Repository navigation
Sync: emit cancelled/rejected orders as failed when the gateway still holds them as pending (issue 0098) - #44
Merged
spbsoluble merged 4 commits intoNov 17, 2026
Conversation
… still holds it as pending Both syncs skip orders cancelled or rejected at CERTInext, and the gateway changes a row only when the sync emits a record for it, so an order it held as pending stayed pending indefinitely (8 kfclab rows, all 'Order Cancelled | Rejected due to Order Cancellation', Track: cancelled). Before skipping, the sync now asks the gateway (ICertificateDataReader.GetStatusByRequestID): held as pending -> emit failed with no certificate, once. No row (ArgumentException), already terminal, issued/revoked (never downgraded), no reader, or a lookup error keep the skip. Summaries gain FailedPropagated. Issue 0098.
…ildcard CN A DV/OV request with CN = apex and SAN = *.apex failed with EMS-1173: the wrapper keys "wildcard" on certificate.domain alone and resolved a plain UCC product. Sending the wildcard as the domain is rejected too (EMS-1056, the domain must match the CSR CN). Both confirmed live. With no template ProductCode, the plugin now reads the catalog and sends the account's single active Wildcard UCC product (typeID 21 DV / 22 OV) as X-Product-Code. No match, several matches, a catalog failure, or EV fails before any order is placed, asking for ProductCode. Adds unit coverage and an opt-in live probe (CERTINEXT_V2_WILDCARD_SAN_PROBE).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sync now marks a cancelled or rejected order as failed when the gateway still holds it as pending. Before, those orders stayed pending forever.
Fixes
The bug: sync skips cancelled and rejected orders, and the gateway only updates a row when sync sends it. An order the gateway already held as pending never got updated.
The fix: before skipping one of these orders, sync checks what the gateway holds for it:
Scope: V1 and V2. The sync summary gains
FailedPropagated, with one Information line per order. Each failed row costs one gateway DB lookup per pass.Testing
DcvSupport=false.SyncTerminalFailurePropagationTests:Other
issues/0098. Stacked on Sync: report product names as ProductID so synced certificates get a template (issue 0097) #43.